Pioneer: Apps adjustments + joy-members reactivation#1156
Merged
mnaamani merged 10 commits intoJoystream:iznikfrom Aug 24, 2020
Merged
Pioneer: Apps adjustments + joy-members reactivation#1156mnaamani merged 10 commits intoJoystream:iznikfrom
mnaamani merged 10 commits intoJoystream:iznikfrom
Conversation
Contributor
Author
|
Member
|
perhaps you could merge iznik to make the PR cleaner to see the changes? |
Contributor
Author
|
Added back "Staking" (Validators) tab which I accidently excluded. |
mnaamani
approved these changes
Aug 24, 2020
This was referenced Sep 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements:
Changes:
polkadot-js/appsbased on our old, modified apps (ie. added providers inApps, added our types to api, addedTopBarwith account dropdown-select, adjusted the routes/tabs). I tried to limit the amout of those changes to the absolute minimum.joy-utils. Moved all required functionality to newjoy-utilsdirectory, did some refactoring and put the files inside a new, more clean directory structure.joy-membersandjoy-pagesand did all the necessary adjustments.Draft:
Based on: #1101
Merged #1153 for new node compatibility
Commits of intrest:
Testing:
yarn workspace pioneer startor use deploy preview at https://deploy-preview-1156--joystream-pioneer.netlify.app/